Set up nodectl end-to-end network test in CI#75
Merged
Keshoid merged 13 commits intorelease/nodectl/v0.4.0from Apr 10, 2026
Merged
Conversation
- modify Makefile to run this script
Keshoid
requested review from
ITBear,
Lapo4kaKek and
mrnkslv
and removed request for
Copilot
…ctl-end-to-end-network-test-in-ci
…n-ci' of github.com:RSquad/ton-rust-node into feature/sma-59-set-up-nodectl-end-to-end-network-test-in-ci
There was a problem hiding this comment.
Pull request overview
This PR sets up end-to-end network testing infrastructure for nodectl in CI by converting a bash bootstrap script to Python, adding support for shared control-client keys in test networks, and implementing a new GitHub Actions workflow for automated testing.
Changes:
- Migrated the singlehost bootstrap script from bash to Python with enhanced logging and structured phases
- Added
--control-client-public-keyargument to test_run_net.py to pre-inject control-client keys into node configs - Implemented
--password-stdinflag in auth command to support non-interactive password input for CI environments - Created GitHub Actions workflow for nodectl e2e testing with proper trigger conditions and artifact upload on failure
- Added Makefile targets for local singlehost integration testing
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/node/tests/test_run_net_py/test_run_net.py | Added control-client key injection function and CLI argument |
| src/node/tests/test_run_net_py/run_singlehost_nodectl.py | New Python bootstrap script with 11 phases for complete setup and testing |
| src/node/tests/test_run_net_py/test_nodectl_ci.sh | New CI wrapper that calls Python script with appropriate environment variables |
| src/node/tests/test_run_net_py/requirements.txt | New file specifying pyyaml dependency |
| src/node-control/Makefile | Added singlehost integration test targets |
| src/node-control/commands/src/commands/nodectl/auth_cmd.rs | Added --password-stdin flag for non-interactive password input |
| .github/workflows/nodectl-e2e.yml | New GitHub Actions workflow for e2e testing |
| .github/workflows/ci.yml | Added paths-ignore configuration for markdown/docs files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Keshoid
changed the title
ITBear
approved these changes
Apr 9, 2026
mrnkslv
reviewed
Apr 10, 2026
|
|
||
| for addr in pool_addrs: | ||
| self.log.info(f" Top up pool {addr} ({self.cfg.pool_topup} TON)") | ||
| self._bun_topup(addr, self.cfg.pool_topup) |
There was a problem hiding this comment.
important to check or edit when core np will be added: will it work normally with ton core np? Nominator pool can have enough funds to stake, but if validator didn't send deposit message with suitable amount it would be impossible to stake
Contributor
Author
There was a problem hiding this comment.
We will adapt the script later.
mrnkslv
approved these changes
Apr 10, 2026
…e/nodectl/ branches
Lapo4kaKek
approved these changes
Apr 10, 2026
Keshoid
deleted the
feature/sma-59-set-up-nodectl-end-to-end-network-test-in-ci
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodectl-e2eGitHub Actions workflow that boots a local 6-node TON network and runs nodectl against it end-to-end. Triggers on PR approval forrelease/nodectl/*, onrun-e2elabel, or via manual dispatch.run_singlehost_nodectl.py) covering 11 phases: build, configure, bootstrap network, configure wallets/pools/nodes, start nodectl service, wait for election participants, and validate via REST API.test_nodectl_ci.shthin CI wrapper with CI-appropriate timeouts and settings.test-e2e,singlehost-venv,stop-e2e) for running the e2e test locally.